Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexget: 2.10.40 -> 2.10.83 #28858

Closed
wants to merge 23 commits into from
Closed

Flexget: 2.10.40 -> 2.10.83 #28858

wants to merge 23 commits into from

Conversation

tari
Copy link
Contributor

@tari tari commented Sep 1, 2017

Motivation for this change

Fixes the build, for progress on #28643.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@tari tari requested a review from FRidh as a code owner September 1, 2017 16:39
@Mic92
Copy link
Member

Mic92 commented Sep 1, 2017

:) #28615

If you want to continue this, could cherry pick the packages, where I moved python packages out of pythonPackages into their own files. This helps in future, because we have automated updates of packages living in python-modules.

@tari
Copy link
Contributor Author

tari commented Sep 1, 2017

Oh, neat. I should have looked before duplicating the work! Will look at 28615 instead.

@tari tari closed this Sep 1, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 1, 2017

I think the pull request updated should go into staging first, as it creates quite a lot of rebuilds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants