rtags: Fix configure phase errors #28852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pkgconfig as buildinput, so that the install path is correctly set with cmake. PkgConfig is an optional dependency for rtags, but they say it's necessary if you want to replace the prefix with CMAKE_INSTALL_PREFIX. See: https://github.com/Andersbakken/rtags/blob/caad9ac494f09960bd60a00061279efacc8d1d26/cmake/BashCompletion.cmake#L13 Furthermore, I let the configurePhase of the rtags emacs package be a noop.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pkgconfig as buildinput, so that the install path is correctly set with cmake. PkgConfig is an optional dependency for rtags, but they say it's necessary if you want to replace the prefix with
CMAKE_INSTALL_PREFIX. See for explanation the rtags repository
Furthermore, I let the configurePhase of the rtags emacs package be a noop, since it only needs to copy the emacs lisp files.
Motivation for this change
This closes issue #24618
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)