john: workaroud for build failure #28855
Merged
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix this build toward #28643 .
The issue appears to be that john's Makefile.in depends on AS and LD be set to CC. For example, it assumes that AS can act as a preprocessor and uses commandline options not available in
as
(like-c
or-DAC_BUILT
)See:
https://github.com/magnumripper/JohnTheRipper/blob/f09bb77afcf5d35226cdcad6a64ecfd0caa64e24/src/Makefile.in#L56
https://github.com/magnumripper/JohnTheRipper/blob/f09bb77afcf5d35226cdcad6a64ecfd0caa64e24/src/Makefile.in#L714
By default, their configure script sets AS and LD to CC--which is why this package used to build before recent setup-hook changes. See:
https://github.com/magnumripper/JohnTheRipper/blob/f09bb77afcf5d35226cdcad6a64ecfd0caa64e24/src/configure.ac#L268
Following the discussion in #28106, I've overridden AS and LD to just use CC.
CC @Ericson2314
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)