Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

john: workaroud for build failure #28855

Merged
merged 1 commit into from Sep 1, 2017

Conversation

danielfullmer
Copy link
Contributor

Motivation for this change

Fix this build toward #28643 .

The issue appears to be that john's Makefile.in depends on AS and LD be set to CC. For example, it assumes that AS can act as a preprocessor and uses commandline options not available in as (like -c or -DAC_BUILT)
See:
https://github.com/magnumripper/JohnTheRipper/blob/f09bb77afcf5d35226cdcad6a64ecfd0caa64e24/src/Makefile.in#L56
https://github.com/magnumripper/JohnTheRipper/blob/f09bb77afcf5d35226cdcad6a64ecfd0caa64e24/src/Makefile.in#L714

By default, their configure script sets AS and LD to CC--which is why this package used to build before recent setup-hook changes. See:
https://github.com/magnumripper/JohnTheRipper/blob/f09bb77afcf5d35226cdcad6a64ecfd0caa64e24/src/configure.ac#L268

Following the discussion in #28106, I've overridden AS and LD to just use CC.

CC @Ericson2314

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@danielfullmer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aszlig, @offlinehacker and @bjornfor to be potential reviewers.

Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting the exact reason why, too!

@7c6f434c 7c6f434c merged commit cc44675 into NixOS:master Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants