Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome3.at-spi2-core: fix service not found error #28856

Merged
merged 1 commit into from Sep 25, 2017

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 1, 2017

Motivation for this change

The service was not registered as a systemd service resulting in errors in the system journal every time a GNOME application was launched.

See: #16327

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The service was not registered as a systemd service resulting in errors
in the system journal every time a GNOME application was launched.

See: NixOS#16327
@@ -34,6 +34,8 @@ with lib;

services.dbus.packages = [ pkgs.at_spi2_core ];

systemd.packages = [ pkgs.at_spi2_core ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a user service or system service?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a user service (located in $out/lib/systemd/user/at-spi-dbus-bus.service).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 Is there anything I should be aware of regarding the user – system distinction?

@Mic92 Mic92 merged commit bda2d25 into NixOS:master Sep 25, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 25, 2017

Thanks!

@jtojnar
Copy link
Contributor Author

jtojnar commented Sep 26, 2017

This could be also cherry picked to 17.09.

@jtojnar jtojnar deleted the at-spi2-core branch September 26, 2017 07:29
@bjornfor
Copy link
Contributor

Seems it already is: edf780b (just a few hours ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants