duplicityBackup module: init at v1.3.0 #28850
Conversation
| }; | ||
|
|
||
| extraConfig = mkOption { | ||
| type = types.str; |
There was a problem hiding this comment.
Consider types.lines here, I think it has more intuitive merge semantics for an option like this.
| }; | ||
| script = '' | ||
| ${cfgPackage}/bin/duplicity-backup.sh \ | ||
| -c /etc/duplicity-backup.conf \ |
There was a problem hiding this comment.
Instead of writing to /etc could you pass the config file directly here or is there some other use for storing the config under /etc specifically?
| ''; | ||
| }; | ||
|
|
||
| onCalendar = mkOption { |
There was a problem hiding this comment.
A potential improvement for the future is to support multiple backup jobs.
| then "yes" else "no" | ||
| }" | ||
| ${optionalString cfg.encryption.enable '' | ||
| PASSPHRASE="${cfg.encryption.passphrase}" |
There was a problem hiding this comment.
Note that the passphrase will end up in the Nix store. Is that a problem?
| } | ||
| ]; | ||
|
|
||
| system.activationScripts.duplicity-backup = stringAfter [ |
There was a problem hiding this comment.
You can do this in the service's preStart. Then it'll run only when the service is started, not on all nixos system activations (likely to be a waste of time).
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "duplicity-backup-sh-${version}"; | ||
| version = "v1.3.0"; |
There was a problem hiding this comment.
The v is not supposed to be in the version part.
|
|
||
| buildInputs = [ makeWrapper ]; | ||
|
|
||
| phases = [ "unpackPhase" "installPhase" ]; |
There was a problem hiding this comment.
Try not to set phases, that should typically only be done by more generic builders. In this case you likely want buildPhase = ":";.
|
This is superseded by #53463. |
Motivation for this change
I wanted to be able to configure encrypted backup using duplicity.
this service is using duplicity-backup.sh to configure and run duplicity
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)