gitea module: init at 1.1.3 #28851
Closed
gitea module: init at 1.1.3 #28851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 1, 2017
| ''; | ||
|
|
||
| systemd.services.gitea = { | ||
| description = "Gitea (Go Git Service)"; |
There was a problem hiding this comment.
"Gitea" is enough here. Reason: on boot it will show the description as name:
Something like:
Starting Gitea...
Mic92
reviewed
Sep 1, 2017
| password = mkOption { | ||
| type = types.str; | ||
| default = ""; | ||
| description = "Database password."; |
There was a problem hiding this comment.
There should be an option to store this in a external file. Explanation: #24288
Mic92
reviewed
Sep 1, 2017
|
|
||
| system.activationScripts.gitea = '' | ||
| mkdir -p ${cfg.stateDir} | ||
| chown -R ${cfg.user}:${cfg.group} ${cfg.stateDir} |
There was a problem hiding this comment.
This might be an expensive operation (if a lot git repositories are present). Since you have allocated static uid/gid number, please only change permission of the root state directory:
install -d -g ${cfg.group} -o ${cfg.user} ${cfg.stateDir}
Mic92
reviewed
Sep 1, 2017
| touch ${cfg.stateDir}/.db-created | ||
| fi | ||
| ''} | ||
| chown -R ${cfg.user}:${cfg.group} ${cfg.stateDir} |
There was a problem hiding this comment.
Here you chown again. I would remove activationsScripts and create stateDir at the beginning of preStart.
|
@disassembler has added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As Gogs has been forked to Gitea I wanted to be able to run gitea.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)