Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdbm: add symlinks for compatibility #29566

Merged
merged 1 commit into from Sep 20, 2017
Merged

gdbm: add symlinks for compatibility #29566

merged 1 commit into from Sep 20, 2017

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 19, 2017

Motivation for this change

some tools check this location to distinguish between gdbm and ndbm.
Archlinux does the same: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/gdbm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from FRidh as a code owner September 19, 2017 11:12
@Mic92 Mic92 changed the base branch from master to staging September 19, 2017 11:12
@Mic92 Mic92 removed the request for review from FRidh September 19, 2017 11:13
@Mic92
Copy link
Member Author

Mic92 commented Sep 19, 2017

@FRidh a little bit weird that you are selected as code owner for this.

@FRidh
Copy link
Member

FRidh commented Sep 19, 2017

@Mic92 yes, I've been getting a lot of review requests for no clear reason. Although, sometimes it happened they modified the PR, and the PR originally contained Python-related files.

@Mic92
Copy link
Member Author

Mic92 commented Sep 19, 2017

Ah, maybe related to the rebase, I did (from master to staging).

@Mic92
Copy link
Member Author

Mic92 commented Sep 19, 2017

don't merge yet, symlink is incorrect.

some tools check this location to distinguish between gdbm and ndbm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants