Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.4 and 3.5: support LD_LIBRARY_PATH #29357

Merged
merged 2 commits into from Sep 15, 2017
Merged

Python 3.4 and 3.5: support LD_LIBRARY_PATH #29357

merged 2 commits into from Sep 15, 2017

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Sep 14, 2017

Motivation for this change

Support for LD_LIBRARY_PATH was added to Python 3.6, fixes #29154.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
python34: check LD_LIBRARY_PATH
03898f2 
Backports support for LD_LIBRARY_PATH from 3.6
@FRidh
python35: check LD_LIBRARY_PATH
77baf6e 
Backports support for LD_LIBRARY_PATH from 3.6
@FRidh FRidh added 6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 14, 2017
@mention-bot
Copy link

@FRidh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @domenkozar, @vcunat and @symphorien to be potential reviewers.

@FRidh FRidh requested a review from abbradar September 14, 2017 08:22
@FRidh FRidh mentioned this pull request Sep 14, 2017
Closed
abbradar
abbradar approved these changes Sep 15, 2017
View reviewed changes
Copy link
Member

@abbradar abbradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Tested with both versions -- it works now.

@FRidh FRidh merged commit fdbe81b into NixOS:master Sep 15, 2017
FRidh added a commit that referenced this pull request Sep 15, 2017
@FRidh
Merge pull request #29357 from FRidh/ld_library_path
e13c497 
Python 3.4 and 3.5: support LD_LIBRARY_PATH

(cherry picked from commit fdbe81b)
@FRidh FRidh deleted the ld_library_path branch September 20, 2017 09:27
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar abbradar approved these changes

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ctypes.util.find_library() is broken on Python 3.4, 3.5
4 participants
@FRidh @mention-bot @abbradar @samueldr