Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kde4workspace and kdetelepathy #29369

Merged
merged 2 commits into from Sep 14, 2017

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Sep 14, 2017

Motivation for this change

As discussed with @ttuegel in #29219, this pr removes kde4_workspace and kde_telepathy as both are not maintained anymore.

Progress on: #28643

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ttuegel
Copy link
Member

ttuegel commented Sep 14, 2017

Does this need to be backported to the release-17.09 branch?

@ttuegel ttuegel merged commit 815135f into NixOS:master Sep 14, 2017
@bkchr
Copy link
Contributor Author

bkchr commented Sep 14, 2017

I think so, because kde4_workspace did not compile without the changes of my other pr.

ttuegel pushed a commit that referenced this pull request Sep 14, 2017
Remove kde4workspace and kdetelepathy

(cherry picked from commit 815135f)
@fpletz fpletz added this to the 17.09 milestone Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants