Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locustio: 0.7.2 -> 0.7.5 #29345

Closed
wants to merge 2 commits into from
Closed

Conversation

disassembler
Copy link
Member

@disassembler disassembler commented Sep 14, 2017

Motivation for this change

fixes build failures.

related to #28643

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@disassembler
Copy link
Member Author

disassembler commented Sep 14, 2017

I tried upgrading gevent to 1.2.2 as default version and that just brought in a mess with nox review (lots of stuff already broken), so I added 1.2.2 instead of upgrading for now. This builds and all dependencies do as well.

@FRidh
Copy link
Member

FRidh commented Sep 14, 2017

Sorry, same as in the previous PR, we don't keep multiple versions.

@disassembler
Copy link
Member Author

Per @FRidh we don't keep multiple versions, so upgrading gevent to 1.2.2. There's lots of build failures with nox review, but a lot of those are broken already and in the list of packages to fix. Splitting out other changes to new PR's and moving locustio into it's own module.

@FRidh
Copy link
Member

FRidh commented Sep 15, 2017

OK, this will need a bit more testing done. I'll keep this one for later.

@globin
Copy link
Member

globin commented Sep 28, 2017

ping, this is broken on the release branch currently

@disassembler
Copy link
Member Author

superseded by #31863 closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants