rabbitmq_server: 3.6.6 -> 3.6.10 #29350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This package could use a maintainer. Since you seem to be using it, would you be up for it? |
|
I'm totally not qualified :) |
FRidh
reviewed
Sep 15, 2017
|
|
||
| src = fetchurl { | ||
| url = "https://github.com/rabbitmq/rabbitmq-server/releases/download/rabbitmq_v3_6_6/rabbitmq-server-3.6.6.tar.xz"; |
There was a problem hiding this comment.
Why not stick with the GitHub url?
https://github.com/rabbitmq/rabbitmq-server/archive/rabbitmq_v3_6_10.tar.gz
There was a problem hiding this comment.
mainly for convenience: the github url has 2 places for the version, one of which is not easy to interpolate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
3.6.6 has some known vulnerabilities: https://pivotal.io/security/cve-2017-4965
3.6.10 was the latest when the change was made at Zalora. I realize there are 3.6.11 and 3.6.12 now, but it'll take a while for another round of updating and testing.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)