s3fs: 1.80 -> 1.82 #29348
Closed
s3fs: 1.80 -> 1.82 #29348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srhb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @nckx and @peterhoeg to be potential reviewers. |
|
Applied to master (fc2566e). Should I backport to release-17.09? |
|
@bjornfor as far as I can tell, users of Amazon S3 are unaffected by the issue, so I don't think a backport is critical. Thanks. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
1.80 had certain bugs related to using non-Amazon s3 implementations (for instance rados gateway,) 1.82 appears to have fixed this
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)