Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgba: 0.5.2 -> 0.6.0 #29347

Merged
merged 1 commit into from Sep 14, 2017
Merged

mgba: 0.5.2 -> 0.6.0 #29347

merged 1 commit into from Sep 14, 2017

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Sep 14, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@AndersonTorres, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MP2E and @dezgeg to be potential reviewers.

@FRidh FRidh merged commit 3e78a50 into NixOS:master Sep 14, 2017
@AndersonTorres AndersonTorres deleted the upload/mgba branch February 23, 2018 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndersonTorres @mention-bot @FRidh