Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eve: 0.6.1 -> 0.7.4 #29342

Merged
merged 2 commits into from Sep 18, 2017
Merged

eve: 0.6.1 -> 0.7.4 #29342

merged 2 commits into from Sep 18, 2017

Conversation

disassembler
Copy link
Member

@disassembler disassembler commented Sep 14, 2017 •
edited

Motivation for this change

Fixes eve build failures.

Related to #28643

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Sep 14, 2017

We do not maintain multiple versions of a package, so this solution won't go in. If there is no other way, we can mark eve as broken.

@disassembler
Copy link
Member Author

I've reached out to eve project on IRC to see if there's a technical reason setup.py requires older versions. If there's not, I can patch setup.py. If there is, I agree, lets mark as broken and move on! Users can always use pypi2nix to use this module with the required python libraries if needed.

@disassembler
Copy link
Member Author

I was able to run eve helloworld demo with this patch.

@fpletz fpletz merged commit 6d367ba into NixOS:master Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@disassembler @FRidh @fpletz