Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack: 2.7.1 -> 2.8.0 #29339

Merged
merged 1 commit into from Sep 19, 2017
Merged

slack: 2.7.1 -> 2.8.0 #29339

merged 1 commit into from Sep 19, 2017

Conversation

benley
Copy link
Member

@benley benley commented Sep 14, 2017

Motivation for this change

Upstream update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz fpletz added this to the 17.09 milestone Sep 15, 2017
@benley benley merged commit 7e60110 into NixOS:master Sep 19, 2017
@benley benley deleted the benley/slack-2.8.0 branch September 19, 2017 16:27
fpletz pushed a commit that referenced this pull request Sep 19, 2017
@benley @fpletz
slack: 2.7.1 -> 2.8.0 (#29339)
609290b 
(cherry picked from commit 7e60110)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benley @fpletz