Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: Do not limit hardenging because gcc 4.9 in bootstrap #29349

Merged
merged 1 commit into from Sep 14, 2017

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Sep 14, 2017

Motivation for this change

GCC in Bootstrap tools has since been bumped

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@edolstra
Copy link
Member

This is showing a merge conflict in coreutils. Other than that looks good.

@globin
Copy link
Member

globin commented Sep 14, 2017

Nice! ❤️ (except for the conflict)

@Ericson2314 Ericson2314 merged commit d94c7f5 into NixOS:staging Sep 14, 2017
@Ericson2314 Ericson2314 deleted the harden-bootstrap branch September 14, 2017 14:31
vcunat added a commit that referenced this pull request Sep 19, 2017
This has been forgotten in #29349 ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants