Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgpdump: disable tests #29353

Merged
merged 1 commit into from Sep 15, 2017
Merged

pgpdump: disable tests #29353

merged 1 commit into from Sep 15, 2017

Conversation

disassembler
Copy link
Member

@disassembler disassembler commented Sep 14, 2017 •
edited

Motivation for this change

Fixes build. Missing file in tarball upstream so need to disable checks.

Related to #28643

In attempting to fix the problem, I switched to use fetchPypi which is cleaner, so left it in.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh FRidh merged commit 56f8b36 into NixOS:master Sep 15, 2017
FRidh added a commit that referenced this pull request Sep 15, 2017
@FRidh
Merge pull request #29353 from disassembler/pgpdump
baee496 
pgpdump: disable tests
(cherry picked from commit 56f8b36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@disassembler @FRidh