pydub 0.16.7 -> 0.20.0 #29351
Merged
pydub 0.16.7 -> 0.20.0 #29351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Sep 14, 2017
pkgs/top-level/python-packages.nix
Outdated
| }; | ||
|
|
||
| buildInputs = [ self.scipy pkgs.ffmpeg-full ]; |
There was a problem hiding this comment.
Is scipy only needed during runtime?
pkgs/top-level/python-packages.nix
Outdated
| url = "https://pypi.python.org/packages/05/e0/8d2496c8ef1d7f2c8ff625be3849f550da42809b862879a8fb137c6baa11/${name}.tar.gz"; | ||
| sha256 = "10rmbvsld5fni9wsvb7la8lblrglsnzd2l1159rcxqf6b8k441dx"; | ||
| version = "0.20.0"; | ||
| src = fetchPypi { |
pkgs/top-level/python-packages.nix
Outdated
| }; | ||
|
|
||
| buildInputs = [ self.scipy pkgs.ffmpeg-full ]; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Could you include here the comment you have in the commit message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fixes build failures.
related to #28643
Had to disable tests because pyaudioop test module hard codes builtins which breaks on python 3.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)