dovecot2: added quota, changed pop3 default #29364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Hi @qknight, this commit seems to break evaluation for me (error: value is null while a string was expected, at /home/rodney/ops/nixpkgs-release/lib/types.nix:222:23). It works when I revert. I haven't got time just now to look further, but here's my config: https://gist.github.com/rvl/b074a4d8d63f7fd35eb1a647d8fb8a90 |
|
It's due to { assertion = cfg.createMailUser -> (cfg.mailUser != null);
message = "services.dovecot2.createMailUser requires mailUser to be set";
}
{ assertion = cfg.createMailUser -> (cfg.mailGroup != null);
message = "services.dovecot2.createMailUser requires mailGroup to be set";
}Cheers |
|
@rvl is that problem still there? |
|
Fixed in f7411b8.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
the
nixcloud.emailabstraction requires some changes and in this case we need to embrace imap over pop3 default. as well as quotas.this PR is related to #29366
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)