Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk+: 3.22.19 -> 3.22.21 #29352

Merged
merged 1 commit into from Sep 14, 2017
Merged

gtk+: 3.22.19 -> 3.22.21 #29352

merged 1 commit into from Sep 14, 2017

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 14, 2017

Motivation for this change

gtk+ 3.22.19 does not build on Darwin (see #29221).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (in a VM)
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dezgeg
Copy link
Contributor

dezgeg commented Sep 14, 2017

@vcunat seems to have touched this recently.

vcunat
vcunat approved these changes Sep 14, 2017
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWS seems safe, and it builds on x86_64-linux. Probably good for master directly (and 17.09).

Estimating rebuild amount by counting changed Hydra jobs.
     67 x86_64-darwin
   1459 x86_64-linux

@vcunat vcunat merged commit 2f70241 into NixOS:master Sep 14, 2017
vcunat added a commit that referenced this pull request Sep 14, 2017
@vcunat
Merge #29352: gtk+: 3.22.19 -> 3.22.21
2a73225
@vbgl
Copy link
Contributor Author

vbgl commented Sep 14, 2017

Thanks Vladimír. Shall I cherry-pick this commit to branch 17.09?

@vcunat
Copy link
Member

vcunat commented Sep 14, 2017

You can. I originally wanted to wait for a day (or so), just in case some breakage appeared, but it will most likely be OK.

@vbgl
Copy link
Contributor Author

vbgl commented Sep 14, 2017

OK. No problem. Let’s wait.

@dezgeg
Copy link
Contributor

dezgeg commented Sep 15, 2017 •
edited

Seems to work (and fix Darwin): https://hydra.nixos.org/eval/1392731

@dezgeg
Copy link
Contributor

dezgeg commented Sep 15, 2017

Pushed in 46a68c8.

@vbgl vbgl deleted the gtk-3_22_21 branch May 22, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @dezgeg @vcunat