Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/fileSystems: Better example path for encrypted.keyFile option #29343

Closed

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Sep 14, 2017

Motivation for this change

The root filesystem is mounted to /mnt-root, not /root during Stage 1,
so the old example doesn't make much sense.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The root filesystem is mounted to /mnt-root, not /root during Stage 1,
so the patch in the old example - /root - normally doesn't exist.
@Moredread Moredread changed the title Better example path for fileSystems.*.encrypted.keyFile nixos/fileSystems: Better example path for encrypted.keyFile option Sep 14, 2017
@joachifm joachifm added this to the 17.09 milestone Sep 17, 2017
@joachifm
Copy link
Contributor

Seems like this was superceded by 77be4d9

@joachifm joachifm closed this Oct 28, 2017
@Moredread Moredread deleted the fix/encrypted-devices-example branch February 5, 2018 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants