Update nexus #28797

ironpinguin · 2017-08-31T15:58:59Z

Motivation for this change

Update and Fix the existing Nexus Repository Server. Also Add a module for the service

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Ma27

I like the changes overall (and I'm glad that you do Nix :P)

Ma27 · 2017-08-31T19:55:49Z

pkgs/development/tools/repository-managers/nexus/nexus-bin.patch

+++ nexus	2017-08-31 12:41:01.271475645 +0200
+@@ -1,4 +1,4 @@
+-#!/bin/sh
+#!/nix/store/axldd4qjamb2c1lgi7d6k3s51qyy4610-bash-4.4-p12/bin/sh


please use patchShebangs . during the patch phase

Was a not need change in the bash script.

I forgot to remove this part of the patch during find out what need to patch. ;-)

Ma27 · 2017-08-31T19:56:28Z

pkgs/development/tools/repository-managers/nexus/default.nix


  meta = with stdenv.lib; {
    description = "Repository manager for binary software components";
    homepage = http://www.sonatype.org/nexus;
    license = licenses.epl10;
    platforms = platforms.all;
-    maintainers = [ maintainers.aespinosa ];
+    maintainers = [ maintainers.aespinosa maintainers.ironpinguin ];


with maintainers; [ aespinosa ironpinguin ]; makes it easier to read/type when adding further maintainers :)

I change it.

NeQuissimus · 2017-08-31T21:35:18Z

nixos/tests/nexus.nix

@@ -0,0 +1,32 @@
+# verifies:


I know where you copied this from :D

Change it now to more reasonable comments ;-)

NeQuissimus · 2017-08-31T21:35:54Z

pkgs/development/tools/repository-managers/nexus/default.nix


  src = fetchurl {
-    url = "https://sonatype-download.global.ssl.fastly.net/nexus/oss/nexus-${version}-bundle.tar.gz";
-    sha256 = "1k3z7kwcmr1pxaxfnak99fq5s8br9zbqbfpyw1afi86ykkph4g5z";
+    url = "https://sonatype-download.global.ssl.fastly.net/nexus/3/nexus-${version}-mac.tgz";


The macOS bundle works cross-platform?!

Yes because there are only two diffrents:

in .install4j folder there comes also a jre.bundle in mac style (if no local jre is installed)

Additional checks for jre in mac style (include fallback to jre.bundle) in startup shell script

And both has no side effects on unix systems (expect the extra 167M for the jre bundle)

I test it on my nixos box.

NeQuissimus · 2017-08-31T21:36:12Z

nixos/tests/nexus.nix

+
+    print $server->execute("sudo -u nexus groups");
+    $server->mustSucceed("sudo -u nexus groups | grep nexus | grep users");
+  '';


Could you add a test that actually checks that the Nexus interface is up?

I can do it. First i add it but got some memory error in the test kvm. But can also come from the situation that i run the nixos in a virtualbox :-(

NeQuissimus · 2017-08-31T21:40:02Z

nixos/modules/services/web-apps/nexus.nix

+
+        ln -sf ${cfg.home} /run/sonatype-work
+
+        chown -R ${cfg.user} ${cfg.home}


Won't make much of a difference but should the chown also take into account the group?

Oh yes i will do it.

NeQuissimus · 2017-08-31T21:41:14Z

Looks pretty good, just a few suggestions here and there

globin · 2017-09-01T07:38:00Z

Commits should be prefixed with nexus: and the version bump be of the form nexus: a.b.c -> x.y,z.

Please also try to squash the commits into logical entities.

Update Nexus to version 3.5.1-02 and fix startup stript to run in nix environment.

Add also myself as maintainer Add simple test of the nexus service

ironpinguin · 2017-09-01T16:26:50Z

@globin now ok?

Mic92 requested a review from NeQuissimus August 31, 2017 17:16

Ma27 reviewed Aug 31, 2017

View reviewed changes

NeQuissimus requested changes Aug 31, 2017

View reviewed changes

ironpinguin added 2 commits September 1, 2017 18:19

nexus: 2.12.0-01 -> 3.5.1-02

044321b

Update Nexus to version 3.5.1-02 and fix startup stript to run in nix environment.

nexus: Add module for nexus.

b66fe76

Add also myself as maintainer Add simple test of the nexus service

NeQuissimus approved these changes Sep 1, 2017

View reviewed changes

globin merged commit 4ea1d49 into NixOS:master Sep 4, 2017

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update nexus #28797

Update nexus #28797

ironpinguin commented Aug 31, 2017 •

edited

Ma27 left a comment

Ma27 Aug 31, 2017

ironpinguin Aug 31, 2017 •

edited

Ma27 Aug 31, 2017

ironpinguin Aug 31, 2017 •

edited

NeQuissimus Aug 31, 2017

ironpinguin Sep 1, 2017

ironpinguin Sep 1, 2017

NeQuissimus Aug 31, 2017

ironpinguin Sep 1, 2017

NeQuissimus Aug 31, 2017

ironpinguin Sep 1, 2017

NeQuissimus Aug 31, 2017

ironpinguin Sep 1, 2017

NeQuissimus commented Aug 31, 2017

globin commented Sep 1, 2017

ironpinguin commented Sep 1, 2017


		ln -sf ${cfg.home} /run/sonatype-work

		chown -R ${cfg.user} ${cfg.home}

Update nexus #28797

Update nexus #28797

Conversation

ironpinguin commented Aug 31, 2017 • edited

Motivation for this change

Things done

Ma27 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ironpinguin Aug 31, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ironpinguin Aug 31, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NeQuissimus commented Aug 31, 2017

globin commented Sep 1, 2017

ironpinguin commented Sep 1, 2017

ironpinguin commented Aug 31, 2017 •

edited

ironpinguin Aug 31, 2017 •

edited

ironpinguin Aug 31, 2017 •

edited