Codegen: don't incorrectly share metadata across llvm modules

crystal-lang · Sep 15, 2017 · b5484e4 · b5484e4
1 parent 3e68043
commit b5484e4
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/compiler/crystal/codegen/debug.cr b/src/compiler/crystal/codegen/debug.cr
@@ -38,8 +38,14 @@ module Crystal
       di_builder.create_subroutine_type(nil, int1)
     end
 
-    def debug_type_cache
-      @debug_types ||= {} of Type => LibLLVMExt::Metadata?
+    def debug_type_cache(llvm_module = @llvm_mod)
+      # We must cache debug types per module so metadata of a type
+      # from one module isn't incorrectly used in another module.
+      debug_types_per_module =
+        @debug_types_per_module ||=
+          {} of LLVM::Module => Hash(Type, LibLLVMExt::Metadata?)
+
+      debug_types_per_module[llvm_module] ||= {} of Type => LibLLVMExt::Metadata?
     end
 
     def get_debug_type(type)