Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell infra, ghc: Slight cleanup #29424

Merged
merged 2 commits into from Sep 15, 2017
Merged

haskell infra, ghc: Slight cleanup #29424

merged 2 commits into from Sep 15, 2017

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Sep 15, 2017 •
edited

Motivation for this change

These changes are good for future cross work. They don't add much benefit now while that stuff doesn't work for other reasons, but they are also harmless in that no hashes are changed.

Reviewing each commit separately will be easier.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Sep 15, 2017
@Ericson2314 Ericson2314 merged commit 2295533 into NixOS:master Sep 15, 2017
@Ericson2314 Ericson2314 deleted the slight-haskell-cleanup branch September 15, 2017 16:12
@peti
Copy link
Member

peti commented Sep 15, 2017

@Ericson2314, what are you doing? I cannot review those changes in less than an hour!

@peti peti mentioned this pull request Sep 15, 2017
Merged
@Ericson2314 Ericson2314 added this to Reverted in Cross compilation Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlevy shlevy shlevy approved these changes

@peti peti Awaiting requested review from peti

Assignees

@shlevy shlevy

Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on
Projects
No open projects
Cross compilation
Reverted
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @peti @shlevy