Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby: 2.4.1 -> 2.4.2 #29417

Merged
merged 1 commit into from Sep 15, 2017
Merged

ruby: 2.4.1 -> 2.4.2 #29417

merged 1 commit into from Sep 15, 2017

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Sep 15, 2017

Motivation for this change

Fixes several security issues: https://www.ruby-lang.org/en/news/2017/09/14/ruby-2-4-2-released/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@manveru, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @pikajude and @NeQuissimus to be potential reviewers.

zimbatm
zimbatm approved these changes Sep 15, 2017
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimbatm
Copy link
Member

zimbatm commented Sep 15, 2017

as a side note, I think we should just export major_minor to the top-level. If people start depending on major_minor_tiny their code is going to break unnecessarily.

@zimbatm zimbatm merged commit 2edb7e9 into NixOS:master Sep 15, 2017
fpletz pushed a commit that referenced this pull request Sep 17, 2017
@manveru @fpletz
ruby: 2.4.1 -> 2.4.2 (#29417)
62e6dcf 
(cherry picked from commit 2edb7e9)
@dogweather
Copy link

How is this installed via nix-env? I only see Ruby 2.4.0 available.

@pbogdan pbogdan mentioned this pull request Oct 7, 2017
Merged
8 tasks
@manveru manveru deleted the ruby-2.4.2 branch November 30, 2017 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manveru @mention-bot @zimbatm @dogweather