wrapGAppsHook: Correct wrapProgram invocations
#29419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes several defects in the way `wrapGAppsHook` selected the executable to wrap. Previously, it would wrap any top-level files in the target `/bin` and `/libexec` directories, including directories and non-executable files. In addition, it failed to wrap files in subdirectories. Now, it uses `find` to iterate over these directory hierarchies, selecting only executable files for wrapping.
|
@timor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @lethalman and @peti to be potential reviewers. |
|
Per 2cd342c#commitcomment-22034819 this commit originally caused some problems for firefox, which were later fixed. I expect we need to backport those fixes as well? |
|
I looked into the source and it seems that particular fix has been applied. I am building firefox to try it out, but that takes a while... |
|
I built a firefox with that fix, and as expected, there are no crashes in open/save dialogs. |
|
Can this be closed? Or merged? |
|
I am not using 17.03 anymore, so for me it is not important right now, but how is the policy regarding backports for old releases? |
|
Closing - it's now in 18.03. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from 2cd342c
Motivation for this change
fixes issue #25756 for 17.03, which has not been backported yet
original commit message below
This change fixes several defects in the way
wrapGAppsHookselectedthe executable to wrap.
Previously, it would wrap any top-level files in the target
/binand/libexecdirectories, including directories and non-executablefiles. In addition, it failed to wrap files in subdirectories.
Now, it uses
findto iterate over these directory hierarchies,selecting only executable files for wrapping.
Things done
Cherry-picked commit, built emacs and tried out hexl-mode, which workds now.
Have not tested any other build. Also built a firefox, seemed to work fine.build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)