Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpi4py: disabling tests #29427

Merged
merged 1 commit into from Sep 18, 2017
Merged

mpi4py: disabling tests #29427

merged 1 commit into from Sep 18, 2017

Conversation

disassembler
Copy link
Member

@disassembler disassembler commented Sep 15, 2017 •
edited

Motivation for this change

disabling tests. Timing out because mpi processes can't communicate with each other.

related to #28643

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@disassembler, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aherrmann, @FRidh and @infinisil to be potential reviewers.

@disassembler
Copy link
Member Author

also fixes h5py

@FRidh
Copy link
Member

FRidh commented Sep 16, 2017

Timing out because mpi processes can't communicate with each other.

Which could be a real issue, since they need to be able to communicate with each other. The question is then, how come they cannot? Is that because of the sandbox?

@disassembler
Copy link
Member Author

It's because of sandboxing. Ran without sandboxing enabled locally. I did have to rename a library in a test to get it to pass as well because of https://bitbucket.org/mpi4py/mpi4py/issues/28/test_dltestdl-test-failure

running install tests
running test
[0@sarov] Python 2.7 (/nix/store/c2fpgdv9iw81gh1pb7sfgasirpr35ymf-python-2.7.13/bin/python2.7)
[0@sarov] MPI 3.0 (Open MPI 1.10.7)
[0@sarov] mpi4py 2.0.0 (build/lib.linux-x86_64-2.7/mpi4py)
...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 1027 tests in 3.659s

OK
/nix/store/7cgq0pblw83qg1y8hinlzqn53asfzad5-python2.7-mpi4py-2.0.0

@fpletz fpletz added this to the 17.09 milestone Sep 18, 2017
@fpletz fpletz merged commit 2f9cb45 into NixOS:master Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@disassembler @mention-bot @FRidh @fpletz