moto: 0.4.25 -> 0.4.31 #29422
Merged
moto: 0.4.25 -> 0.4.31 #29422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@disassembler, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jyp, @FRidh and @infinisil to be potential reviewers. |
disassembler
force-pushed
the
gensim
branch
from
ece4b57
to
49fac1f
Compare
disassembler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes gensim by adding required build dependency of moto.
Also upgrades moto to 0.4.31. 1.x is out now, but it breaks compatibility so I think we should stick with 0.4.31 for 17.09 release.
related to #28643
Looking at this further, gensim doesn't need moto, it depends on smart_open, which requires moto, so I rebased and pulled out the gensim commit. This fixes both the gensim and smart_open builds that were failing.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)