awesome-slugify: fixes tests #29428
Merged
awesome-slugify: fixes tests #29428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome-slugify test fix that was using numero sign which is now decoded by unidecode in latest release to "No.". from unidecode changelog: Add U+2116 NUMERO SIGN (thanks to Alan Davidson). all dependent packages build successfully now. |
disassembler
force-pushed
the
unidecode
branch
from
1b23da4
to
08d5d81
Compare
disassembler
force-pushed
the
unidecode
branch
from
08d5d81
to
0b4b88c
Compare
disassembler
changed the title
|
also, 151d0fd should be cherry picked with this to 17.09. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
unidecode was fixed in 151d0fd
Updated PR to just fix awesome-slugify tests that break because of newer unidecode version in #29334
related to #28643
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)