Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arelle: enable only on python 3.4 DON'T MERGE #29421

Closed
wants to merge 1 commit into from
Closed

arelle: enable only on python 3.4 DON'T MERGE #29421

wants to merge 1 commit into from

Conversation

roberth
Copy link
Member

@roberth roberth commented Sep 15, 2017 •
edited

Motivation for this change

Python 3.4 is the version suggested by arelle.org
On other versions, the build fails, so this PR disables those.

Equivalent pr for release-17.09: #29420

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@roberth
arelle: enable only on python 3.4
3ea2328 
Python 3.4 is the version suggested by arelle.org
@roberth roberth mentioned this pull request Sep 15, 2017
Merged
8 tasks
@roberth roberth changed the title arelle: enable only on python 3.4 arelle: enable only on python 3.4 DONT MERGE Sep 15, 2017
@roberth
Copy link
Member Author

roberth commented Sep 15, 2017

This needs to be reworked because of #29435

@roberth roberth changed the title arelle: enable only on python 3.4 DONT MERGE arelle: enable only on python 3.4 DON'T MERGE Sep 15, 2017
@roberth
Copy link
Member Author

roberth commented Sep 19, 2017

Closing, because problems have been fixed for 3.4 and 3.6 on master, as can be seen on https://hydra.nixos.org/eval/1394026?filter=arelle&compare=1393889&full=

@roberth roberth closed this Sep 19, 2017
@roberth roberth deleted the master-arelle branch September 19, 2017 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@roberth