Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arelle: enable only on python 3.4 (merge as necessary) #29420

Merged
merged 1 commit into from Sep 21, 2017
Merged

arelle: enable only on python 3.4 (merge as necessary) #29420

merged 1 commit into from Sep 21, 2017

Conversation

roberth
Copy link
Member

@roberth roberth commented Sep 15, 2017 •
edited

Motivation for this change

Python 3.4 is the version suggested by arelle.org
On other versions, the build fails, so this PR disables those.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@roberth roberth mentioned this pull request Sep 15, 2017
Closed
8 tasks
@roberth roberth changed the title arelle: enable only on python 3.4 arelle: enable only on python 3.4 DON'T MERGE Sep 15, 2017
@roberth
Copy link
Member Author

roberth commented Sep 19, 2017 •
edited

TLDR: merge this if the root cause of the problem on py36 is not solved before release 17.09. I'm taking a break.

Ok, the current situation is arelle on python3.6 works on the master branch, but for some reason, it does not build on the release branch. The cause of the problem seems to be outside the arelle build definition, considering that the arelle directory is the same in both branches.

If the problem causing the failure persists until the release, please merge this PR. Arelle is a 'niche' package that I have introduced into nixpkgs only recently. Normal users will use it on 3.4 ('official' version) anyway, because that's the definition of pkgs.arelle. Python 3.6 support is only relevant for developers who must use the latest Python for some reason. I don't expect this group of people to exist. If they do exist, they can use nixpkgs master instead. Very hypothetical. Please worry about relevant nixpkgs issues instead.

I'm taking a break, so someone else should make the decision if necessary.

@roberth roberth changed the title arelle: enable only on python 3.4 DON'T MERGE arelle: enable only on python 3.4 (merge as necessary) Sep 19, 2017
@Mic92 Mic92 merged commit 0c59c5f into NixOS:release-17.09 Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roberth @Mic92