Revert "haskell infra, ghc: Slight cleanup" #29430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could reopen now and wait for your review, but I think it would be most productive to find some time to meet and go over the changes in real time. I'm happy to separate the cross infra from purely cosmetic refactors (indeed that was mostly done along the lines of commit 1 vs 2, but it could be separate PRs). Due note in some cases the cosmetic ones were to paper over pointless differences between different GHC versions' nix files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #29424. Please don't merge extensive changes like that without giving me any chance to comment. I am not happy about some of the modifications, particularly the random reformatting of code that serves no purpose but makes diffs with previous versions or branches more extensive than necessary and hard to read.