Skip to content

Commit

Permalink
protobufc: add missed file
Browse files Browse the repository at this point in the history
  • Loading branch information
@abbradar
abbradar committed Sep 9, 2017
1 parent 554ed27 commit 0d55804
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions pkgs/development/libraries/protobufc/1.3.nix
View file
@@ -0,0 +1,11 @@
{ callPackage, fetchFromGitHub, ... } @ args:

callPackage ./generic.nix (args // rec {
version = "1.3.0";
src = fetchFromGitHub {
owner = "protobuf-c";
repo = "protobuf-c";
rev = "v${version}";
sha256 = "0shk18rjhzn2lqrwk97ks3x8gj77isc8szyb3xsgjrbrvkzjgvaa";
};
})

3 comments on commit 0d55804

@peti
Copy link
Member

@peti peti commented on 0d55804 Sep 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nixpkgs still doesn't evaluate. :-(

$ nix-env -qaP --json >/dev/null --show-trace                                   .nix-defexpr/git/master !
error: while evaluating ‘callPackageWith’ at /home/simons/.nix-defexpr/lib/customisation.nix:113:35, called from /home/simons/.nix-defexpr/pkgs/top-level/all-packages.nix:16114:11:
while evaluating ‘makeOverridable’ at /home/simons/.nix-defexpr/lib/customisation.nix:72:24, called from /home/simons/.nix-defexpr/lib/customisation.nix:117:8:
undefined variable ‘protobuf2_5’ at /home/simons/.nix-defexpr/pkgs/top-level/all-packages.nix:16115:16

@abbradar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange; I have definitely missed it but doesn't nox-review catch such errors?

@abbradar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and it does, so it seems I failed to invoke between some change and just before submitting a PR. Working on a fix, sorry!

Please sign in to comment.