Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxqt-session: fix the build #29132

Merged
merged 1 commit into from Sep 9, 2017
Merged

lxqt-session: fix the build #29132

merged 1 commit into from Sep 9, 2017

Conversation

matklad
Copy link
Member

@matklad matklad commented Sep 8, 2017

closes #29130

Motivation for this change

Fix the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matklad
Copy link
Member Author

matklad commented Sep 8, 2017

Confirmed that after this fix LXQT actually works, yay!

@joachifm joachifm merged commit 21c526d into NixOS:master Sep 9, 2017
@matklad matklad deleted the lxqt-session branch September 9, 2017 13:14
@joachifm
Copy link
Contributor

joachifm commented Sep 9, 2017

Picked to release as well

@matklad matklad mentioned this pull request Sep 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lxqt fails to build on 17.09
2 participants
@matklad @joachifm