Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs: workaround for upstream bug; other small fixes #29133

Merged
merged 3 commits into from Sep 18, 2017
Merged

ipfs: workaround for upstream bug; other small fixes #29133

merged 3 commits into from Sep 18, 2017

Conversation

elitak
Copy link
Contributor

@elitak elitak commented Sep 8, 2017 •
edited

Motivation for this change

Temporary workaround for ipfs/kubo#4214

Things done

Running ipfs repo fsck prestart should be safe, and fixes the service not starting after an unclean exit.

Also, the ipfs autoMount now works, although I had to take the suboptimal approach of adding a line to environment.etc."fuse.conf".text.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@elitak elitak mentioned this pull request Sep 16, 2017
Merged
8 tasks
@mguentner
Copy link
Contributor

Looks good to me now (it appears that you force pushed). Software is just great that depends on terminating newlines ;)
Could you please fetch and merge https://github.com/mguentner/nixpkgs/tree/ipfs_test_new into this PR?

@fpletz fpletz added this to the 17.09 milestone Sep 18, 2017
@elitak
Copy link
Contributor Author

elitak commented Sep 18, 2017

Oh, took me a while to get what you mean. Yeah, and I had mkIf not high up enough as well.

I've added your tests change (+ removal of "not yet" comments) and rebased.

@fpletz fpletz merged commit decaa2e into NixOS:master Sep 18, 2017
@fpletz
Copy link
Member

fpletz commented Sep 18, 2017

Thank you both! 🍻

@Ekleog Ekleog mentioned this pull request Apr 12, 2018
Closed
@matthewbauer matthewbauer mentioned this pull request Apr 21, 2018
Closed
7 tasks
@vojta001
Copy link
Contributor

@elitak According to ipfs/kubo#4214 (specifically this comment) the issue has been resolved. Can't we remove the ipfs repo fsck?

@elitak elitak mentioned this pull request Apr 14, 2020
Closed
10 tasks
@elitak
Copy link
Contributor Author

elitak commented Apr 20, 2020

@vojta001 Turns out we still need ipfs repo fsck because the daemon is still dying to systemd and leaving behind the /var/lib/ipfs/api lockfile. I can't be bothered to chase down why; trying to report bugs upstream has proven highly unproductive.

@elitak elitak mentioned this pull request Apr 20, 2020
Closed
9 tasks
@vojta001
Copy link
Contributor

@elitak I have no experience with ipfs developers, however, if the release notes for go-ipfs 0.5 are correct, it should truly be no longer necessary (nor available, in fact).

Proposed in #86242.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
0.kind: enhancement 8.has: module (update)
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elitak @mguentner @fpletz @vojta001