Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl-ApacheTest: mark broken #29155

Closed
wants to merge 1 commit into from
Closed

Conversation

timor
Copy link
Member

@timor timor commented Sep 9, 2017

Motivation for this change

Package does not build due to failing tests. Also tried version 1.40, same problem.
Unable to find out why the tests fail. It could be that during the test phase, a getprotobyname('tcp') call fails in an unexpected manner.

A quick search on my side did not turn up any packages which depend on this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

meta = {
# tests fail
broken = true;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a } here.

@rycee rycee self-assigned this Sep 10, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 10, 2017

related to NixOS/nix#275

@rycee
Copy link
Member

rycee commented Sep 10, 2017

@Mic92 Ah, interesting. So perhaps doCheck = false; is better suited than broken = true;?

Mic92 added a commit that referenced this pull request Sep 10, 2017
fixes #29155

(cherry picked from commit 87eafdc)
@Mic92
Copy link
Member

Mic92 commented Sep 10, 2017

I have a fix for the test in 87eafdc

@Mic92 Mic92 closed this in 87eafdc Sep 10, 2017
@rycee
Copy link
Member

rycee commented Sep 10, 2017

Nice! I didn't know about this trick. Thanks :-)

@timor timor deleted the perl-ApacheTest-broken branch September 10, 2017 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants