Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Updates k2pdfopt to 2.42 for #28643
I use this package infrequently, but I'd like to see it working in 17.09. It was a pain to package properly--it includes a number of .c and .h files that are intended to replace the corresponding files in the upstream packages. I've used overrideAttrs to enable this more nicely than including an ad-hoc build script like before. (Note that I had to use mupdf 1.10a instead of the more recent version in nixpkgs 1.11, since the .c files in k2pdfopt are written just for 1.10a)
This also includes a modification to "gocr" to install libraries and include files so it can compile in k2pdfopt. However, I've disabled the GOCR engine since it crashes for me while testing. The tesseract OCR engine works much better in most cases anyway.
I've tested the executable works, as well as the optional functionality enabled by tesseract, mupdf, ghostscript, and jasper.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)