Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python fixes #29136

Closed
wants to merge 3 commits into from
Closed

Python fixes #29136

wants to merge 3 commits into from

Conversation

teh
Copy link
Contributor

@teh teh commented Sep 8, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh FRidh changed the title This is for zero hydra failures. Python fixes Sep 9, 2017
@FRidh FRidh added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 9, 2017
@FRidh
Copy link
Member

FRidh commented Sep 9, 2017

flake8 and mccabe don't seem to need any patching, or is it related due to #29103?

@teh
Copy link
Contributor Author

teh commented Sep 9, 2017

Ah, RuntimeError: dictionary changed size during iteration is indeed what I ran into. I'll close this branch and re-retest now that #29103 is fixed.

@teh teh closed this Sep 9, 2017
@FRidh
Copy link
Member

FRidh commented Sep 9, 2017

Still, we may want those commits because I intend to get the distutils.cfg commit back in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python 9.needs: port to stable A PR needs a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teh @FRidh