Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uwsgi: enable plugins by default #29145

Closed
wants to merge 1 commit into from
Closed

uwsgi: enable plugins by default #29145

wants to merge 1 commit into from

Conversation

bachp
Copy link
Member

@bachp bachp commented Sep 9, 2017

Motivation for this change

Plugins are just shared libraries. Enabling all supported plugins
makes it easier to use uwsgi without needing to recompile it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bachp
uwsgi: enable plugins by default
9790a2d 
Plugins are just shared libraries. Enabling all supported plugins
makes it easier to use uwsgi without needing to recompile it.
@orivej
Copy link
Contributor

orivej commented Sep 29, 2017 •
edited

Plugins bring unneeded dependencies. For example, php is unlikely to be installed without this change. If you really need this, please add uwsgi-full top-level derivation, or separate uwsgi-python2, uwsgi-rack etc. Only cgi seems a reasonable additional default.

@bachp
Copy link
Member Author

bachp commented Sep 29, 2017

@orivej You are right I din't think about that. I will close this PR as I don't think it is worth to add such additional special derivations.

@bachp bachp closed this Sep 29, 2017
@orivej
Copy link
Contributor

orivej commented Sep 29, 2017

OK, but if you always use uwsgi with one additional plugin, I'd approve its top-level derivation so that it can be installed from the binary cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bachp @orivej