Update protobuf and remove old versions #29134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leaves only protobuf3_1 which is the last version with libprotobuf2. Also fix several packages to build with the latest protobuf.
|
Do you think we should backport (some) of this? Maybe not the removal of the older versions, but the addition and changing the default we might. |
|
Hm, if we backport at least the addition I can then also backport new TensorFlow, maybe along with my other ML-related commits (current packages are somewhat outdated). Not sure about the default (but it'd make backporting other things easier). |
|
Please fix 6589ee8#commitcomment-24187697 before backporting. |
|
Fixed in 0d55804, thanks again. |
|
trezord depends on protobuf 2.6 and is broken by this change. Please restore protobuf2_6. (cc @jb55) |
|
Fixed in 27a4820 by rebuilding protobuf files like described in https://github.com/trezor/trezord. Sorry for the breakage! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
First motivation was to update protobuf to 3.4 so that TensorFlow 1.3 could be used. Later I updated all nixpkgs to use protobuf 3.4 (the latest version), sans one package that needs an old version (3.1).
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)Remaining packages which don't build with this change seem to fail because of unrelated reason.