Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perl-File-Modified: 0.07 -> 0.10 #29153

Closed
wants to merge 1 commit into from
Closed

perl-File-Modified: 0.07 -> 0.10 #29153

wants to merge 1 commit into from

Conversation

timor
Copy link
Member

@timor timor commented Sep 9, 2017

Motivation for this change

Build-time tests were failing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@rycee
Copy link
Member

rycee commented Sep 9, 2017

I'd suggest to use the package as generated by nix-generate-from-cpan:

  FileModified = buildPerlPackage rec {
    name = "File-Modified-0.10";
    src = fetchurl {
      url = "mirror://cpan/authors/id/N/NE/NEILB/${name}.tar.gz";
      sha256 = "6b50b1aab6ec6998a017f6403c2735b3bc1e1cf46187bd134d7eb6df3fc45144";
    };
    meta = {
      homepage = https://github.com/neilbowers/File-Modified;
      description = "Checks intelligently if files have changed";
      license = with stdenv.lib.licenses; [ artistic1 gpl1Plus ];
    };
  };

Then you also get a nice meta section :-)

@timor
Copy link
Member Author

timor commented Sep 9, 2017

done

@rycee
Copy link
Member

rycee commented Sep 9, 2017

Looking good. Rebased into master in e480b4b. Thanks!

I'll cherry-pick this and your previous PR into 17.09 (and maybe 17.03) as well.

@rycee rycee closed this Sep 9, 2017
@timor timor deleted the perl-File-Modified-0.10 branch September 9, 2017 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timor @rycee