Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mupen64plus: 1.5 -> 2.5 #29150

Merged
merged 1 commit into from Sep 11, 2017
Merged

mupen64plus: 1.5 -> 2.5 #29150

merged 1 commit into from Sep 11, 2017

Conversation

Lassulus
Copy link
Member

@Lassulus Lassulus commented Sep 9, 2017

Motivation for this change

building with GCC6
getting zero hydra errors: #28643

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Lassulus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @globin, @Fuuzetsu and @aske to be potential reviewers.

@AndersonTorres
Copy link
Member

I will not test it, but update meta.homepage attribute to http://www.mupen64plus.org/.

@Lassulus Lassulus force-pushed the mupen64-update branch 2 times, most recently from 978420d to fe7fc1a Compare September 9, 2017 16:28
@Mic92 Mic92 merged commit ee9b549 into NixOS:master Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Lassulus @mention-bot @AndersonTorres @Mic92