Remove travis OSX build #4942
Remove travis OSX build #4942
Conversation
RX14
added
kind:bug
.travis.yml
Outdated
| matrix: | ||
| fast_finish: true |
There was a problem hiding this comment.
There's no reason to remove fast_finish. We still have multiple builds and notifying the author as soon as one of them fails is still nice to have.
There was a problem hiding this comment.
I read the fast_finish docs and it made it sound as if it was only valid with allow_failures.
There was a problem hiding this comment.
With fast finishing enabled, Travis CI will mark your build as finished as soon as one of two conditions are met: The only remaining jobs are allowed to fail, or a job has already failed.
https://blog.travis-ci.com/2013-11-27-fast-finishing-builds/
|
I disagree with the big amount of spacing added. Not to mention that it's less clear what the change is. |
|
Why do you dislike the spacing? It's a lot clearer with whitespace between each section. I also split it into 2 commits so the diff was clear. |
RX14
force-pushed
the
bugfix/remove-travis-osx
branch
from
fbac252 to
fcfcf9c
Compare
|
Let's ping approved PR authors to rebase so they don't block the queues |
|
I don't think that's needed. Config is not taken from PRs, that's insecure |
|
@oprypin so why did this PR not build OSX? |
|
Hm nevermind. But I still think everything will work out without manual rebasing. PRs get rebased anyway. |
|
@oprypin but we want green CI before they're rebased onto master. |
|
Ah, so this is about PRs that failed the last time they were checked. Have you tried simply restarting the build in the Travis interface? |
|
@oprypin no, this is about fixing PRs hanging in the "queueing" status for several days. |
|
Restarting the build in Travis runs on the targets defined before this PR. But I think that's ok really. Let's see in a case by case basis, as needed. |
Travis's OSX infastructure is extremely overloaded. We think that the excess of OSX jobs is filling up our travis "build slots" and causing linux builds not to run. To remedy this we've recided to remove OSX from travis, as we already have circleci.