Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/transmission: make it possible to use a different home directory #29138

Merged
merged 1 commit into from Sep 9, 2017
Merged

nixos/transmission: make it possible to use a different home directory #29138

merged 1 commit into from Sep 9, 2017

Conversation

eqyiel
Copy link
Contributor

@eqyiel eqyiel commented Sep 9, 2017

Motivation for this change

I wanted transmission to put its home dir elsewhere, but currently it's hardcoded as "/var/lib/transmission".

While it's possible to override the user transmission's home dir by something like users.users.transmission.home = lib.mkForce "/mnt/whatever"; the ExecStart script would still try to create directories at the path specified in this file (/var/lib/transmission).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@eqyiel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @unaizalakain, @bjornfor and @thoughtpolice to be potential reviewers.

@Mic92 Mic92 changed the title transmission.nix: make it possible to use a different home directory nixos/transmission: make it possible to use a different home directory Sep 9, 2017
bjornfor
bjornfor approved these changes Sep 9, 2017
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please change the commit prefix from "transmission.nix:" to "nixos/transmission:".

@joachifm joachifm merged commit 4ff9e9e into NixOS:master Sep 9, 2017
@joachifm
Copy link
Contributor

joachifm commented Sep 9, 2017

Thank you. Note that changing the PR title does not affect the commit subject (I changed it via squash).

@eqyiel
Copy link
Contributor Author

eqyiel commented Sep 10, 2017

Thanks!

@eqyiel eqyiel deleted the transmission-with-variable-home-dir branch September 10, 2017 03:44
fpletz pushed a commit that referenced this pull request Sep 10, 2017
@eqyiel @fpletz
nixos/transmission: make it possible to use a different home directory (
05f1c24 
#29138)

(cherry picked from commit 4ff9e9e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eqyiel @mention-bot @joachifm @bjornfor