Add modules for tinydns and dnscache from djbdns #29450
Conversation
| mv -iv djbdns-man/*.$n man/man$n; | ||
| done; | ||
| rm -rv djbdns-man; | ||
| ''; |
There was a problem hiding this comment.
What about meta? Do you want to maintain this package?
There was a problem hiding this comment.
Sorry, forgot to add that -- fixed in new commits!
| wantedBy = [ "multi-user.target" ]; | ||
| path = with pkgs; [ daemontools djbdns ]; | ||
| preStart = '' | ||
| rm -rf /var/lib/tinydns; |
There was a problem hiding this comment.
If the data is nuked on every startup, is there a benefit to allocating a static uid?
There was a problem hiding this comment.
I think not, but I didn't realize until I saw @Mic92's commits that it was even possible to not allocate a static uid. :) Will look into it.
nixos/modules/misc/ids.nix
Outdated
| @@ -297,6 +297,8 @@ | |||
| clickhouse = 278; | |||
| rslsync = 279; | |||
| minio = 280; | |||
| tinydns = 281; | |||
| dnscache = 282; | |||
There was a problem hiding this comment.
Why did you remove these commits again?
with improvements suggested by Jörg Thalheim <joerg@thalheim.io>
with improvements suggested by Jörg Thalheim <joerg@thalheim.io>
|
Okay, I think all the issues have been addressed in the new versions of these commits that I just pushed. I've confirmed that I get working dns servers out of all of this. Please have another look -- thanks! |
|
|
||
| config = mkIf config.services.dnscache.enable { | ||
| environment.systemPackages = [ pkgs.djbdns ]; | ||
| users.extraUsers.dnscache = {}; |
There was a problem hiding this comment.
Is the dnscache service supposed to run as this user? If so, add serviceConfig.User = "dnscache" to the unit definition below. I expect it then needs PermissionsStartOnly = true as well for the preStart script to work.
There was a problem hiding this comment.
or does it do privsep itself, perhaps?
There was a problem hiding this comment.
It does it itself also because it binds port 53.
(not strictly required to start the service)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)