nixos/pfix-srsd: add module #29452
Merged
nixos/pfix-srsd: add module #29452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerith666
force-pushed
the
pfix-srsd-1709
branch
from
4339044
to
8b68927
Compare
joachifm
reviewed
Sep 17, 2017
| }; | ||
|
|
||
| secret = mkOption { | ||
| description = "The secret data used to encode the SRS address"; |
There was a problem hiding this comment.
How important is it that this remains secret? If at all, consider not copying it into the store.
There was a problem hiding this comment.
I think it is rather important -- possession of this secret means you can forge bounces through this mail server. Looking into duplicating the approach used by postsrsd.nix.
joachifm
reviewed
Sep 17, 2017
| description = "Whether to run the postfix sender rewriting scheme daemon."; | ||
| }; | ||
|
|
||
| domain = mkOption { |
There was a problem hiding this comment.
Please declare types for the options.
jerith666
force-pushed
the
pfix-srsd-1709
branch
from
8b68927
to
1c1bfb2
Compare
jerith666
force-pushed
the
pfix-srsd-1709
branch
from
1c1bfb2
to
0ece5fc
Compare
|
Okay, secrets moved out of store and types added. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)