Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poezio-git: init at 0.11-44-gc88459c #29437

Closed
wants to merge 1 commit into from
Closed

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Sep 15, 2017

Motivation for this change

make a more recent version of poezio available

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Sep 15, 2017

Thanks for the PR, but:

  • we typically include only a single version. If we have multiple, including development releases, there has to be a good motivation;
  • this is a CLI application, and not a Python library. Therefore, it doesn't belong in python-packages.nix and python-modules. Note that the current poezio should be moved as well.

I'll be closing this now.

@FRidh FRidh closed this Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants