Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cairo: 1.14.10 -> 1.15.8 #29458

Closed
wants to merge 1 commit into from
Closed

cairo: 1.14.10 -> 1.15.8 #29458

wants to merge 1 commit into from

Conversation

vyp
Copy link
Member

@vyp vyp commented Sep 16, 2017

Motivation for this change

Emojis

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
This doesn't build, not sure why.. any ideas? 
$ nix-build -A cairo -K
these derivations will be built:
  /nix/store/d096bg77p22zv5ciffk199vqqsq7y8x8-cairo.drv
  /nix/store/am09rq9myssrq114n02kkd4697g2rv29-cairo-1.15.8.drv
building path(s) ‘/nix/store/xma5yxnyzz5shd89fam8gi6j4zs8la3l-cairo’
exporting https://anongit.freedesktop.org/git/cairo (rev 1.15.8) into /nix/store/xma5yxnyzz5shd89fam8gi6j4zs8la3l-cairo
Initialized empty Git repository in /nix/store/xma5yxnyzz5shd89fam8gi6j4zs8la3l-cairo/.git/
remote: Counting objects: 3202, done.
remote: Compressing objects: 100% (3134/3134), done.
remote: Total 3202 (delta 383), reused 2125 (delta 59)
Receiving objects: 100% (3202/3202), 31.75 MiB | 259.00 KiB/s, done.
Resolving deltas: 100% (383/383), done.
From https://anongit.freedesktop.org/git/cairo
 * tag               1.15.8     -> FETCH_HEAD
Switched to a new branch 'fetchgit'
removing `.git'...
building path(s) ‘/nix/store/3v7d3mzxmdydp7b70sjk21zkn00msbm7-cairo-1.15.8-dev’, ‘/nix/store/b93yalsc4g5qlfm8033vbs0l6cma96hi-cairo-1.15.8-devdoc’, ‘/nix/store/v91gv17s6lv82yhbabw9d3vj0rg28yzc-cairo-1.15.8’
unpacking sources
unpacking source archive /nix/store/xma5yxnyzz5shd89fam8gi6j4zs8la3l-cairo
source root is cairo
patching sources
applying patch /nix/store/hrvsw11xgc50zix0djc19gi8kds3234s-cairo-CVE-2016-9082.patch
patching file boilerplate/cairo-boilerplate.c
patching file src/cairo-image-compositor.c
patching file src/cairo-image-surface-private.h
patching file src/cairo-mesh-pattern-rasterizer.c
patching file src/cairo-png.c
patching file src/cairo-script-surface.c
configuring
no configure script, doing nothing
building
no Makefile, doing nothing
glibPreInstallPhase
installing
install flags: install pkgconfigdir=/nix/store/3v7d3mzxmdydp7b70sjk21zkn00msbm7-cairo-1.15.8-dev/lib/pkgconfig m4datadir=/nix/store/3v7d3mzxmdydp7b70sjk21zkn00msbm7-cairo-1.15.8-dev/share/aclocal aclocaldir=/nix/store/3v7d3mzxmdydp7b70sjk21zkn00msbm7-cairo-1.15.8-dev/share/aclocal gsettingsschemadir=/nix/store/v91gv17s6lv82yhbabw9d3vj0rg28yzc-cairo-1.15.8/share/gsettings-schemas/cairo-1.15.8/glib-2.0/schemas/
make: *** No rule to make target 'install'.  Stop.
note: keeping build directory ‘/tmp/nix-build-cairo-1.15.8.drv-0’
builder for ‘/nix/store/am09rq9myssrq114n02kkd4697g2rv29-cairo-1.15.8.drv’ failed with exit code 2
error: build of ‘/nix/store/am09rq9myssrq114n02kkd4697g2rv29-cairo-1.15.8.drv’ failed

@vcunat
Copy link
Member

vcunat commented Sep 16, 2017

My understanding is that 1.15.x is an unstable branch. I'm intentionally keeping gtk/gnome-related packages on stable versions (even minor numbers).

@vyp
Copy link
Member Author

vyp commented Sep 16, 2017

Oh I didn't know that, but I guess that explains why they seem to have two sets of releases. That's fair enough, but I'm curious is there any particular reason for keeping it on the stable 1.14.x, other than just stability? This latest release brings emoji (color glyph) support so I felt that feature was significant enough for an immediate update.

Closing in favour of waiting for a 1.14.x release.

@vyp vyp closed this Sep 16, 2017
@vyp vyp deleted the cairo-1.15.8 branch September 16, 2017 09:20
@vcunat
Copy link
Member

vcunat commented Sep 16, 2017

I'm not sure. I didn't see such things explicitly described around upstream. It might be easiest to just ask them somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vyp @vcunat