arelle: 2017-06-01 -> 2017-08-24 #29435
Conversation
disassembler
force-pushed
the
arelle
branch
2 times, most recently
from
84eb09f
to
50fcbcb
Compare
disassembler
changed the title
|
@roberth can I get a review since your the maintainer? |
| CDATApattern = re.compile(r"<!\[CDATA\[(.+)\]\]") | ||
| #EFM table 5-1 and all &xxx; patterns | ||
| -docCheckPattern = re.compile(r"&\w+;|[^0-9A-Za-z`~!@#$%&\*\(\)\.\-+ \[\]\{\}\|\\:;\"'<>,_?/=\t\n\r\m\f]") # won't match &#nnn; | ||
| +docCheckPattern = re.compile(r"&\w+;|[^0-9A-Za-z`~!@#$%&\*\(\)\.\-+ \[\]\{\}\|\\:;\"'<>,_?/=\t\n\r\f]") # won't match &#nnn; |
There was a problem hiding this comment.
I had to look this up. The table mentioned in the comment ( EFM table 5-1 in https://www.sec.gov/info/edgar/edgarfm-vol2-v25.pdf ) does not seem to include anything that warrants the \m. Also it's hard to find a meaning for \m in a python regex. Probably ok. I'll check with the author asynchronously.
|
@disassembler, thank you for looking into this. Removing the |
| @@ -46,6 +49,8 @@ buildPythonPackage { | |||
| (cd apidocs && make html && cp -r _build $doc) | |||
| ''; | |||
|
|
|||
| doCheck = if gui then true else false; | |||
|
|
|||
There was a problem hiding this comment.
I think python2 is no longer supported. ./bin/arelle is python3-only and https://github.com/Arelle/Arelle/blob/master/setup.py#L424 only lists python3
disassembler
force-pushed
the
arelle
branch
from
50fcbcb
to
d15c019
Compare
Motivation for this change
fixes tests for python 3.6.
Remove \m from regex (not supported anymore)
Also, implicitly specify from arelle import in Cntlr in CntlrProfiler.py
arelle released a new release for RedHat on 2017-08-24, so I'm considering code from that date a stable release.
tests break on headless expecting tkinter library, so tests are only ran on when gui == true.
related to #28643
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)