fcitx-engines.rime: init at 0.3.2 #29460
Conversation
| libyamlcpp, gmock }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "librime"; |
There was a problem hiding this comment.
The version needs to be part of name.
| name = "librime"; | ||
| version = "1.2.9"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
You can use fetchFromGitHub here:
{
src = fetchFromGitHub {
owner = "rime";
repo = "librime";
rev = "rime-${version}";
sha256 = "...";
};
}
sifmelcara
force-pushed
the
add/rime
branch
3 times, most recently
from
ef091c6
to
9e74ee1
Compare
|
Thanks for the review! |
sifmelcara
force-pushed
the
add/rime
branch
2 times, most recently
from
99d0dd2
to
6d9b6e9
Compare
|
Hello, what's the status? |
pkgs/data/misc/brise/default.nix
Outdated
| # may be released under different licenses | ||
| license = licenses.gpl3; | ||
| platforms = platforms.all; | ||
| maintainers = [ maintainers.mingchuan ]; |
There was a problem hiding this comment.
While you wait, you should probably update this to match your new username (and same in the other files and lib/maintainers.nix). :)
There was a problem hiding this comment.
Hmm, sifmelcara is my GitHub handle, and mingchuan is the name I used in git commit messages.
However, I can change my name in lib/maintainers.nix so that people can easily ping me on GitHub.
There was a problem hiding this comment.
Oh right, my bad. Yeah at the top of lib/maintainers.nix it says github handle is preferred, thanks. ✨
orivej
force-pushed
the
add/rime
branch
3 times, most recently
from
88b4956
to
c3417c7
Compare
|
I've simplified build expressions and enabled parallel building. Thank you for your contribution! |
Motivation for this change
Add fcitx support for Rime input method and Rime's dependencies.
About the
brisepackage: This package provides data for many variants of Chinese input methods. Since it will try to download data from GitHub (if data do not already exists), we need to fetch those dialect's data manually.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)